[libcxx-commits] [PATCH] D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings

[Xing Xue via Phabricator via libcxx-commits]

xingxue added a comment.

> TBH, `cxa_personality` is somewhat below what I usually touch, so I don't really have a concern here.
>
> I'd like to note that this patch does trigger `-Wunused-parameter`, though - would it be possible to fix those, or are those seemingly unused parameters actually necessary to reduce the diff between upstream and a downstream fork?

Thanks for catching the unused parameter warning, @ldionne ! I will open a separate NFC patch to address it.  This patch was committed yesterday morning but somehow not closed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101545/new/

https://reviews.llvm.org/D101545