[libcxx-commits] [PATCH] D101545: [libc++abi] NFC: adding a new parameter base to functions for calculating addresses with relative encodings
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jun 10 12:03:14 PDT 2021
ldionne added a comment.
In D101545#2796567 <https://reviews.llvm.org/D101545#2796567>, @compnerd wrote:
> I’d say wait a day or so to make sure that @ldionne doesn’t have any concerns, but this seems like it should be safe. Rebasing a pointer seems like a useful enough thing and this don’t impact the public interfaces.
TBH, `cxa_personality` is somewhat below what I usually touch, so I don't really have a concern here.
I'd like to note that this patch does trigger `-Wunused-parameter`, though - would it be possible to fix those, or are those seemingly unused parameters actually necessary to reduce the diff between upstream and a downstream fork?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101545/new/
https://reviews.llvm.org/D101545
More information about the libcxx-commits
mailing list