[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

Wed Jun 9 13:29:35 PDT 2021

ldionne added a comment.

In D103947#2808442 <https://reviews.llvm.org/D103947#2808442>, @phosek wrote:

> In D103947#2807992 <https://reviews.llvm.org/D103947#2807992>, @ldionne wrote:
>
>> Is this configuration being tested by a bot? Who is it important for?
>>
>> This looks good to me, except for the principle that we should not attempt to half-support configurations that we don't commit to testing - instead we should clearly state that those are not supported and simplify the library to not even try to support them. I'm 100% fine with this patch and supportive of this if I can get an answer to the questions above.
>
> This is important for us, I'm trying to set up Fuchsia toolchain build for Windows and I ran into this issue in the runtimes build, this manifests when building compiler-rt (libFuzzer) using the just built Clang and libc++. I hope this also answers the question of testing, once this lands I'll (re-)enable the use of libc++ in our Windows toolchain build which is going cover this configuration.
>
> We could also consider setting up Buildkite pipeline for Windows if we want coverage in libc++ presubmit testing although that's probably more work.

It's the bare minimum for a configuration to be considered as supported. We already have a Windows bot, but I'm actually not sure whether it's using MinGW or straight Windows. @mstorsjo will know. Maybe it's trivial to add another Windows configuration to test this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947