[libcxx-commits] [PATCH] D103947: [libcxx] Fix using the vcruntime ABI with _HAS_EXCEPTIONS=0 defined

Wed Jun 9 10:22:06 PDT 2021

phosek added inline comments.

================
Comment at: libcxx/include/__config:225
+#  define _LIBCPP_ABI_VCRUNTIME
+#  if defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS == 0
+#    define _LIBCPP_NO_EXCEPTIONS
----------------
Microsoft STL seems to be using `_HAS_EXCEPTIONS` [unconditionally](https://github.com/microsoft/STL/blob/62137922ab168f8e23ec1a95c946821e24bde230/stl/inc/exception#L30) presumably because vcruntime always defines it? I wonder if we should do the same to avoid accidentally going in the `else` branch if someone sets `_LIBCPP_ABI_VCRUNTIME` even when vcruntime isn't being used, I'd rather get an error in that case.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103947/new/

https://reviews.llvm.org/D103947