[libcxx-commits] [PATCH] D103734: [libcxx] moves <utility> content out of <type_traits> and into their own headers
    Christopher Di Bella via Phabricator via libcxx-commits 
    libcxx-commits at lists.llvm.org
       
    Tue Jun  8 11:36:01 PDT 2021
    
    
  
cjdb added a comment.
In D103734#2801111 <https://reviews.llvm.org/D103734#2801111>, @Mordante wrote:
> I like this direction! I assume the patch has no changes in the moved code.
> LGTM modulo one minor nit.
I made //one// minor change to `swap`, where I replaced the return type (which was obfuscated by ifdefs) with an alias so the compiler selection doesn't screw up readability.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103734/new/
https://reviews.llvm.org/D103734
    
    
More information about the libcxx-commits
mailing list