[libcxx-commits] [PATCH] D103734: [libcxx] moves <utility> content out of <type_traits> and into their own headers

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jun 8 11:29:59 PDT 2021


cjdb marked 2 inline comments as done.
cjdb added a comment.

In D103734#2805384 <https://reviews.llvm.org/D103734#2805384>, @ldionne wrote:

> I'd like to better understand the motivation for this patch - are you working towards something specific? Generally LGTM.

I'm breaking down `<functional>` into appropriate units so that `__functional` and friends can disappear (they don't play well with the module map and are really clunky to begin with).
`<utility>` needs to be broken down first, in order to achieve that.

So, I guess the final destination of this patch is to see `<utility>` and `<functional>` broken down. `<type_traits>` will likely get taken along for the ride too, but I have no (immediate) intention of looking at that header as a whole.



================
Comment at: libcxx/include/__decay_copy.h:1
+// -*- C++ -*-
+//===----------------------------------------------------------------------===//
----------------
ldionne wrote:
> Why is this at the top level?
I didn't really know where to put it. It's in `__type_traits` now, but I should probably move it to `__utility` before merging.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103734/new/

https://reviews.llvm.org/D103734



More information about the libcxx-commits mailing list