[libcxx-commits] [PATCH] D103583: [libcxx][gardening] Move all algorithms into their own headers.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D103583#2797366 <https://reviews.llvm.org/D103583#2797366>, @Quuxplusone wrote:

> Also: I assume it's intentional that you went with `half_positive.h` instead of `__half_positive.h`, and so on? (I.e., some of these files define standard algorithms and some define helpers, with no clear naming distinction between the two kinds.)

Agreed that we should probably get a convention going. We can do that offline, but I've been following whatever is the salient feature of the file. If it's `__half_positive`, then I'd make the header `__half_positive.h`.



================
Comment at: libcxx/include/module.modulemap:295
+
+      export *
+    }
----------------
This `export *` still needs to go.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103583/new/

https://reviews.llvm.org/D103583