[libcxx-commits] [PATCH] D103583: [libcxx][gardening] Move all algorithms into their own headers.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added a comment.

Double-check your `module.modulemap` changes: I still see at least one `export *` in there.
Also some removed blank lines that may or may not have been on purpose. Just make sure the style we end up with is consistent across all the sections of `module.modulemap`.
Otherwise, sure, LGTM (modulo my usual curmudgeoning that all these little headers are gonna be icky).

Also: I assume it's intentional that you went with `half_positive.h` instead of `__half_positive.h`, and so on? (I.e., some of these files define standard algorithms and some define helpers, with no clear naming distinction between the two kinds.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103583/new/

https://reviews.llvm.org/D103583