[libcxx-commits] [PATCH] D106840: [libcxx][ranges] Add `std::ranges::single_view`.
Zoe Carver via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Jul 27 09:27:29 PDT 2021
zoecarver marked 2 inline comments as done.
zoecarver added inline comments.
================
Comment at: libcxx/test/std/ranges/range.factories/range.single.view/assign.pass.cpp:14
+
+// Tests that <value_> is a <copyable-box>.
+
----------------
cjdb wrote:
> I think these should be backticks, not angle brackets.
We decided to use angle brackets for the exposition only types.
================
Comment at: libcxx/test/std/ranges/range.factories/range.single.view/begin.pass.cpp:71
+ test();
+// static_assert(test());
+
----------------
cjdb wrote:
> Commented out.
Good catch, thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106840/new/
https://reviews.llvm.org/D106840
More information about the libcxx-commits
mailing list