[libcxx-commits] [PATCH] D106840: [libcxx][ranges] Add `std::ranges::single_view`.

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb requested changes to this revision.
cjdb added a comment.
This revision now requires changes to proceed.

Please add concept conformance tests!



================
Comment at: libcxx/test/std/ranges/range.factories/range.single.view/assign.pass.cpp:14
+
+// Tests that <value_> is a <copyable-box>.
+
----------------
I think these should be backticks, not angle brackets.


================
Comment at: libcxx/test/std/ranges/range.factories/range.single.view/begin.pass.cpp:71
+  test();
+//   static_assert(test());
+
----------------
Commented out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106840/new/

https://reviews.llvm.org/D106840