[libcxx-commits] [PATCH] D106404: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151

[Muiez Ahmed via Phabricator via libcxx-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rG6ba493d81b07: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151 (authored by NancyWang2222, committed by muiez).
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106404/new/

https://reviews.llvm.org/D106404

Files:
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
  libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp


Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
@@ -17,6 +17,9 @@
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value different from ASCII character.
 // UNSUPPORTED: target={{.+}}-zos{{.*}}
 
 #include <locale>
Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
@@ -15,6 +15,9 @@
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value different from ASCII character.
 // UNSUPPORTED: target={{.+}}-zos{{.*}}
 
 #include <locale>
Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
@@ -17,6 +17,9 @@
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value different from ASCII character.
 // UNSUPPORTED: target={{.+}}-zos{{.*}}
 
 #include <locale>
Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
@@ -17,6 +17,9 @@
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value different from ASCII character.
 // UNSUPPORTED: target={{.+}}-zos{{.*}}
 
 #include <locale>
Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
@@ -15,6 +15,9 @@
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value different from ASCII character.
 // UNSUPPORTED: target={{.+}}-zos{{.*}}
 
 #include <locale>
Index: libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
===================================================================
--- libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
+++ libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
@@ -17,6 +17,9 @@
 // This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
 // ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
 
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value different from ASCII character.
 // UNSUPPORTED: target={{.+}}-zos{{.*}}
 
 #include <locale>


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106404.360521.patch
Type: text/x-patch
Size: 5358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210721/84d0b5fc/attachment.bin>