[libcxx-commits] [libcxx] 6ba493d - [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151
Muiez Ahmed via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Jul 21 10:49:54 PDT 2021
Author: Nancy Wang
Date: 2021-07-21T13:49:04-04:00
New Revision: 6ba493d81b07c814ac9332bb93ba8a01565020a7
URL: https://github.com/llvm/llvm-project/commit/6ba493d81b07c814ac9332bb93ba8a01565020a7
DIFF: https://github.com/llvm/llvm-project/commit/6ba493d81b07c814ac9332bb93ba8a01565020a7.diff
LOG: [SystemZ][z/OS][libcxx]: add the missing comment for patch D106153 and D106151
This patch is to add the missing comments in https://reviews.llvm.org/D106153 and https://reviews.llvm.org/D106151 to address comments.
Differential Revision: https://reviews.llvm.org/D106404
Added:
Modified:
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
Removed:
################################################################################
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
index 804444be56a72..9204ea26b9c9f 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_in.pass.cpp
@@ -17,6 +17,9 @@
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value
diff erent from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale>
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
index 52fdc299f7dc7..98c5824a3d4a0 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_length.pass.cpp
@@ -15,6 +15,9 @@
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value
diff erent from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale>
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
index 430d8a2140d54..a8f16fcc29a14 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char16_t_out.pass.cpp
@@ -17,6 +17,9 @@
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value
diff erent from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale>
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
index cce5aacb84a71..74cc4793aaf9a 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_in.pass.cpp
@@ -17,6 +17,9 @@
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value
diff erent from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale>
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
index 4d5e6e7e05f89..f51a9db212a29 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_length.pass.cpp
@@ -15,6 +15,9 @@
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value
diff erent from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale>
diff --git a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
index b96120ca62618..379b607a80eea 100644
--- a/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
+++ b/libcxx/test/std/localization/locale.categories/category.ctype/locale.codecvt/locale.codecvt.members/char32_t_out.pass.cpp
@@ -17,6 +17,9 @@
// This test runs in C++20, but we have deprecated codecvt<char(16|32), char, mbstate_t> in C++20.
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_DEPRECATION_WARNINGS
+// Test is intended to convert between UTF8 and UTF16/32, it will fail on
+// z/OS since at default char type on z/OS is EBCDIC character which has
+// value
diff erent from ASCII character.
// UNSUPPORTED: target={{.+}}-zos{{.*}}
#include <locale>
More information about the libcxx-commits
mailing list