[libcxx-commits] [PATCH] D106067: [libc++] Add a CMake target to re-generate files and revamp CONTRIBUTING.rst

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/utils/CMakeLists.txt:18
+            libcxx-generate-feature-test-macros
+    COMMENT "Create all the auto-generated files in libc++ and its tests.")
----------------
I'd strongly prefer "one name for one thing": name the targets consistently with what scripts they run.
So:
`libcxx-generate-header-inclusion-tests`
`libcxx-generate-header-tests`
`libcxx-generate-feature-test-macro-components`

Otherwise LGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106067/new/

https://reviews.llvm.org/D106067