[libcxx-commits] [PATCH] D106067: [libc++] Add a CMake target to re-generate files and revamp CONTRIBUTING.rst

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Nice improvement. I noticed you already committed it after I started reviewing. But LGTM, just a few nits.



================
Comment at: libcxx/docs/Contributing.rst:14
+automation (e.g. CI) that depends on the review being submitted that way.
 
 Looking for pre-existing reviews
----------------
I think it would be nice to refer new contributors to the libcxx Discord channel.


================
Comment at: libcxx/docs/Contributing.rst:41
 
-When adding or updating feature-test macros, you should update the corresponding tests.
-To do that, modify ``feature_test_macros`` table in the script
-``utils/generate_feature_test_macro_components.py``, run it, and commit updated
-files. Running ``utils/generate_feature_test_macro_components.py`` should never
-generate diffs in a clean checkout; feel free to run it in your local checkout
-any time you want.
+- Did you add the relevant feature test macro(s) for your feature? Did you update the ``generate_feature_test_macro_components.py`` script with it?
+- Did you run the ``libcxx-generate-files`` target and verify its output?
----------------
Maybe a linebreak after the first `?`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106067/new/

https://reviews.llvm.org/D106067