[libcxx-commits] [PATCH] D105568: [libc++] Guard testing implementation details.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante updated this revision to Diff 357133.
Mordante added a comment.

Addresses review comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105568/new/

https://reviews.llvm.org/D105568

Files:
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
  libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp


Index: libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp
===================================================================
--- libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp
+++ libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp
@@ -39,8 +39,8 @@
     context.next_arg_id();
     assert(false);
   } catch (const std::format_error& e) {
-    assert(strcmp(e.what(), "Using automatic argument numbering in manual "
-                            "argument numbering mode") == 0);
+    LIBCPP_ASSERT(strcmp(e.what(), "Using automatic argument numbering in manual "
+                                   "argument numbering mode") == 0);
     return;
   }
   assert(false);
Index: libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
===================================================================
--- libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
+++ libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
@@ -39,8 +39,8 @@
       context.check_arg_id(0);
       assert(false);
     } catch (const std::format_error& e) {
-      assert(strcmp(e.what(), "Using manual argument numbering in automatic "
-                              "argument numbering mode") == 0);
+      LIBCPP_ASSERT(strcmp(e.what(), "Using manual argument numbering in automatic "
+                                     "argument numbering mode") == 0);
       return;
     }
     assert(false);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105568.357133.patch
Type: text/x-patch
Size: 1595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210708/667cf363/attachment.bin>