[libcxx-commits] [PATCH] D105568: [libc++] Guard testing implementation details.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM, but it would be more consistent to replace both with `LIBCPP_ASSERT`.



================
Comment at: libcxx/test/std/utilities/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp:43
+#ifdef _LIBCPP_VERSION
       assert(strcmp(e.what(), "Using manual argument numbering in automatic "
                               "argument numbering mode") == 0);
----------------
We have `LIBCPP_ASSERT`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105568/new/

https://reviews.llvm.org/D105568