[libcxx-commits] [PATCH] D105585: [libcxx][nfc] Remove <algorithm>'s dependence on <iterator> and related changes.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.

Zoe and I just spoke.

He's going to turn this into a NFC where we don't remove includes from the "public" headers, but still split stuff out of `<memory>`.

In a follow-up patch, we can try to break the cycle between `<variant>` and `<array>` by using a raw C array in `variant`'s implementation and removing `#include <array>` from `<variant>`. Yes, that will be a breaking change. But I don't think we need a formal release note and discussion for just that one - we've been making small breaking changes such as this without even noticing it for years. While we should have a discussion if we're going to do something major and systematic like in D104980 <https://reviews.llvm.org/D104980>, we shouldn't prevent ourselves from making progress for something as simple as this.

This LGTM once the patch is updated to be a NFC (giving thumbs up proactively because we're not in the same time zone and I want this to be unblocked).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105585/new/

https://reviews.llvm.org/D105585