[libcxx-commits] [PATCH] D105585: [libcxx][nfc] Remove <algorithm>'s dependence on <iterator> and related changes.

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added a comment.

> EDIT: if we need to remove something, we'll need to precisely document it in our release notes (including why we needed to push the deletion ahead of schedule), and give users the chance to respond to this change.

If we want to use variant in common_iterator (which I am neutral on at best) we do //need// to remove something. We can do one of the following:

1. Remove <iterator> and <algorithm> from <array>
2. Remove <memory> and <iterator> from <algorithm> (current).

Putting this here preemptively: based on recent discussions, I'm going to do the first one, as that seems to be lower-impact. I'm also going to keep all the changes to internal headers, but make sure that external headers still provide the same includes (except for <array>).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105585/new/

https://reviews.llvm.org/D105585