[libcxx-commits] [PATCH] D102045: [libc++] Provide 'buildhost-<platform> feature for the tests.

[Vlad Vereschaka via Phabricator via libcxx-commits]

vvereschaka added a comment.

> Would it make sense for that to be a full triple instead of just the result of sys.platform?

I think it would be much easier using а short representation of platform name instead of a full triple and especially if it corresponds to the target platform names, but with the prefixes or something similar.
Also it is not always possible to get a correct triple for the windows platform.

> Also, where would that feature be used?



- workarounds (as @mstorsjo mentioned - D102048 <https://reviews.llvm.org/D102048>).
- host specific tests.

Not sure it will be used often.

> I suggest we add a feature named host=<name-of-the-host>.

No objection, but looks like unusual representation for the feature.
So it may look like that:

  // REQUIRES: host=linux && host=darwin
  ...
  // UNSUPPORTED: host=windows

is this that expected?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102045/new/

https://reviews.llvm.org/D102045