[libcxx-commits] [PATCH] D102045: [libc++] Provide 'buildhost-<platform> feature for the tests.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D102045#2858536 <https://reviews.llvm.org/D102045#2858536>, @ldionne wrote:

> Also, where would that feature be used? It would be helpful for me to understand which tests benefit from that feature. In general, we try not to add features if they are not used anywhere.

I don't think it matters to have a full triple for the build host - in a cross testing scenario, we know the exact triple of the target we're compiling for, but we know pretty little about the host we're driving the tests from - within the python environment we don't know much else than what python tells us.

In D102045#2858536 <https://reviews.llvm.org/D102045#2858536>, @ldionne wrote:

> Also, where would that feature be used? It would be helpful for me to understand which tests benefit from that feature. In general, we try not to add features if they are not used anywhere.

I think this was meant to be used as a different workaround for the thing that was fixed in D102048 <https://reviews.llvm.org/D102048>, but there might be other cases that could need this as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102045/new/

https://reviews.llvm.org/D102045