[libcxx-commits] [PATCH] D93166: [libc++][format] Add basic_format_parse_context.
Mark de Wever via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Jan 28 09:13:57 PST 2021
Mordante added a comment.
In D93166#2528368 <https://reviews.llvm.org/D93166#2528368>, @ldionne wrote:
> This LGTM, but I would prefer if we stuck to the current convention and used `std::__throw_format_error` instead. Not a blocking comment.
Thanks for the review! My diversion of the convention was up for discussion ;-) So I'll switch back to the convention and use `std::__throw_format_error`. I'll commit after it passes CI.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93166/new/
https://reviews.llvm.org/D93166
More information about the libcxx-commits
mailing list