[libcxx-commits] [PATCH] D93166: [libc++][format] Add basic_format_parse_context.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 28 08:24:23 PST 2021


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

This LGTM, but I would prefer if we stuck to the current convention and used `std::__throw_format_error` instead. Not a blocking comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93166/new/

https://reviews.llvm.org/D93166



More information about the libcxx-commits mailing list