[libcxx-commits] [PATCH] D93414: [libc++] Adds a make_string test helper function.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 28 08:17:55 PST 2021


ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/test/support/make_string.h:25
+// facilities.
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
+// Helper function to convert a const char* string to a basic_string<CharT>.
----------------
That is not going to work when the test suite is run against non-libc++. Can we replace by something that doesn't depend on libc++?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93414/new/

https://reviews.llvm.org/D93414



More information about the libcxx-commits mailing list