[libcxx-commits] [PATCH] D93414: [libc++] Adds a make_string test helper function.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D93414#2525656 <https://reviews.llvm.org/D93414#2525656>, @Mordante wrote:

> In D93414#2522792 <https://reviews.llvm.org/D93414#2522792>, @curdeius wrote:
>
>> LGTM. Just 2 nits.
>> Have you looked at what @mstorsjo did in his series of patches for porting filesystem to Windows? I have a vague idea that there were some converting utilities similar to this one.
>
> Thanks for the review. I've didn't have a close look at @mstorsjo's changes. @mstorsjo do you have code in review with similar functionality?

Not entirely sure what that'd refer to - maybe there's some similarity to https://reviews.llvm.org/D90222#change-3lQgyuTryhdf - with the MultiStringType class that I modified for similar cases (with some char types being optionally available).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93414/new/

https://reviews.llvm.org/D93414