[libcxx-commits] [PATCH] D94718: [libc++] Unbreak the debug mode

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 27 10:09:33 PST 2021


ldionne added a comment.

In D94718#2521489 <https://reviews.llvm.org/D94718#2521489>, @vvereschaka wrote:

> Hi @ldionne,
>
> [...]
>
> A possible fix is linking the test within local folder and pass a short library path into the linker such as `./t.tmp.lib`. I.e. replace the second RUN line with something like
>
>   RUN: cd %T && %{cxx} %{flags} %{compile_flags} %s ./t.tmp.lib %{link_flags} -fPIC -DTU2 -D_LIBCPP_DEBUG=1 -fvisibility=hidden -o %t.exe
>
> I have tested these changes on my local build system and it works, but I'm not sure how it will work on the other systems.

Thanks for the detailed explanation. This should be fixed by 90407b16b1d3e38f1360b6a24ceab801ab9cefc1 <https://reviews.llvm.org/rG90407b16b1d3e38f1360b6a24ceab801ab9cefc1>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94718/new/

https://reviews.llvm.org/D94718



More information about the libcxx-commits mailing list