[libcxx-commits] [PATCH] D94718: [libc++] Unbreak the debug mode

Mon Jan 25 15:59:14 PST 2021

vvereschaka added a comment.

Hi @ldionne,

here is a problem with `extern-templates.sh.cpp` test on the windows-to-linux ARM cross builders

http://lab.llvm.org:8011/#/builders/60/builds/1666
http://lab.llvm.org:8011/#/builders/119/builds/1962

the problem looks like

  /tmp/libcxx.3WqvVHTiFB/t.tmp.exe: error while loading shared libraries: C:/buildbot/as-builder-2/x-aarch64/build/runtimes/runtimes-bins/libcxx/test/libcxx/debug/Output/extern-templates.sh.cpp.dir/t.tmp.lib: cannot open shared object file: No such file or directory

`clang` stores a full path to `t.tmp.lib` into the test executable and this path is unavailable when the test gets running on the remote host (over ssh).

A possible fix is linking the test within local folder and pass a short library path into the linker such as `./t.tmp.lib`. I.e. replace the second RUN line with something like

  RUN: cd %T && %{cxx} %{flags} %{compile_flags} %s ./t.tmp.lib %{link_flags} -fPIC -DTU2 -D_LIBCPP_DEBUG=1 -fvisibility=hidden -o %t.exe

I have tested these changes on my local build system and it works, but I'm not sure how it will work on the other systems.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94718/new/

https://reviews.llvm.org/D94718