[libcxx-commits] [PATCH] D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties
Brad Smith via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Jan 23 22:17:02 PST 2021
brad added inline comments.
================
Comment at: libcxx/src/random.cpp:192
return ent;
+#elif defined(__OpenBSD__)
+ return std::numeric_limits<unsigned int>::digits;
----------------
curdeius wrote:
> Just asking. I guess it cannot happen that the first branch of #if is true in OpenBSD, right?
Yes, this RNDGETENTCNT ioctl is Linux specific.
================
Comment at: libcxx/src/random.cpp:193
+#elif defined(__OpenBSD__)
+ return std::numeric_limits<unsigned int>::digits;
#else
----------------
curdeius wrote:
> Please use result_type here or changed to unsigned above for consistency.
Ok.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94571/new/
https://reviews.llvm.org/D94571
More information about the libcxx-commits
mailing list