[libcxx-commits] [PATCH] D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/src/random.cpp:192
   return ent;
+#elif defined(__OpenBSD__)
+  return std::numeric_limits<unsigned int>::digits;
----------------
Just asking. I guess it cannot happen that the first branch of #if is true in OpenBSD, right?


================
Comment at: libcxx/src/random.cpp:193
+#elif defined(__OpenBSD__)
+  return std::numeric_limits<unsigned int>::digits;
 #else
----------------
Please use result_type here or changed to unsigned above for consistency.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94571/new/

https://reviews.llvm.org/D94571