[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 2 inline comments as done.
Mordante added inline comments.


================
Comment at: libcxx/include/format:16
+namespace std {
+  // [format.context], class template basic_format_context
+  template<class Out, class charT> class basic_format_context;
----------------
ldionne wrote:
> Mordante wrote:
> > ldionne wrote:
> > > The synopsis should only contain the parts that we implement. Or at least it's always been my impression.
> > I'll update it in the next version.
> Ping on this. We should remove the part of the synopsis that we don't implement (and of course we should re-add it as we implement more parts of it).
I thought I had done this, but apparently not :-( I've removed it now.


================
Comment at: libcxx/src/format.cpp:13
+
+#if _LIBCPP_STD_VER > 17
+
----------------
ldionne wrote:
> We muse always compile this into the library, so there should be no guard. The built library must be able to work with headers in any standard mode, which means it needs to contain the required definitions for all standard modes. Furthermore, this is always true anyway since we compile the library with C++20.
Thanks for the explanation. I wasn't aware the library should always be compiled with the latest C++ version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214