[libcxx-commits] [PATCH] D92214: [libc++] Implement format_error.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/format:16
+namespace std {
+  // [format.context], class template basic_format_context
+  template<class Out, class charT> class basic_format_context;
----------------
Mordante wrote:
> ldionne wrote:
> > The synopsis should only contain the parts that we implement. Or at least it's always been my impression.
> I'll update it in the next version.
Ping on this. We should remove the part of the synopsis that we don't implement (and of course we should re-add it as we implement more parts of it).


================
Comment at: libcxx/src/format.cpp:13
+
+#if _LIBCPP_STD_VER > 17
+
----------------
We muse always compile this into the library, so there should be no guard. The built library must be able to work with headers in any standard mode, which means it needs to contain the required definitions for all standard modes. Furthermore, this is always true anyway since we compile the library with C++20.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92214/new/

https://reviews.llvm.org/D92214