[libcxx-commits] [PATCH] D94924: [libc++] first steps of a private modulemap

[Thorsten via Phabricator via libcxx-commits]

tschuett added a comment.

You can see it as proof of concept. If you don't like, feel free to reject.



================
Comment at: libcxx/include/__undef_macros_private:12
+#ifdef min
+#if !defined(_LIBCPP_DISABLE_MACRO_CONFLICT_WARNINGS)
+#if defined(_LIBCPP_WARNING)
----------------
ldionne wrote:
> Can you please indent nested preprocessor directives?
It should be a plain copy of__undef_macros?!?


================
Comment at: libcxx/include/module.modulemap:4
-// include cycle.
-module std_config [system] [extern_c] {
-    header "__config"
----------------
ldionne wrote:
> Why is this not an issue anymore? We still reference this module below in `module std`, don't we?
The problem is that there are two modules in module.modulemap. Private modules don't work with having two modules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94924/new/

https://reviews.llvm.org/D94924