[libcxx-commits] [PATCH] D94924: [libc++] first steps of a private modulemap

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Is this ready for review? If not, please ping me when it is. In the meantime, I'll "request changes" so it shows up correctly in the queue.



================
Comment at: libcxx/include/__undef_macros_private:12
+#ifdef min
+#if !defined(_LIBCPP_DISABLE_MACRO_CONFLICT_WARNINGS)
+#if defined(_LIBCPP_WARNING)
----------------
Can you please indent nested preprocessor directives?


================
Comment at: libcxx/include/module.modulemap:4
-// include cycle.
-module std_config [system] [extern_c] {
-    header "__config"
----------------
Why is this not an issue anymore? We still reference this module below in `module std`, don't we?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94924/new/

https://reviews.llvm.org/D94924