[libcxx-commits] [PATCH] D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative

[Hubert Tong via Phabricator via libcxx-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: libcxx/CMakeLists.txt:536
+  if (ZOS)
+    add_definitions(-D_LARGE_TIME_API) # Needed for struct timespec64.
+  endif()
----------------
ldionne wrote:
> Can you bury this into `gettod.h`?
That may be insufficient if the system headers with the affected interfaces get included before `gettod.h` is reached.


================
Comment at: libcxx/include/support/ibm/gettod.h:26
+   struct _t {
+      unsigned long hi;
+      unsigned long lo;
----------------
Are the `unsigned long`s in this file supposed to differ in size by address mode? If not, I suggest using the uint//N//_t typedefs.


================
Comment at: libcxx/src/chrono.cpp:168
+  if (0 != __gettod(&ts))
+        __throw_system_error(errno, "failed to obtained time of day");
+
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93542/new/

https://reviews.llvm.org/D93542