[libcxx-commits] [PATCH] D93542: [SystemZ][ZOS] Provide CLOCK_MONOTONIC alternative

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

If you say it's monotonic..

I would like to reiterate what I've said before: without a build bot, this code will rot. I believe the right order here would be to add a build bot (and have it fail), and then work towards making it green.



================
Comment at: libcxx/CMakeLists.txt:536
+  if (ZOS)
+    add_definitions(-D_LARGE_TIME_API) # Needed for struct timespec64.
+  endif()
----------------
Can you bury this into `gettod.h`?


================
Comment at: libcxx/include/support/ibm/gettod.h:19
+
+inline int __gettod(struct timespec64 *output) {
+
----------------
Can you please use a name that conveys more meaning? Something like `gettimeofday_monotonic` maybe?


================
Comment at: libcxx/src/chrono.cpp:163
+#elif defined(__MVS__)
+#include <support/ibm/gettod.h>
+
----------------
Don't `#include` here -- you're `#include`ing inside a namespace. Please place this include at the top of the file, with other includes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93542/new/

https://reviews.llvm.org/D93542