[libcxx-commits] [PATCH] D94824: [MSVC] Disable <fstream> usage of <filesystem>

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/include/fstream:190
+
+#if _LIBCPP_STD_VER >= 17 && !defined(_MSC_VER)
 #include <filesystem>
----------------
I'm not entirely fond of hardcoding the condition like this - would it be better to emit something to `__config` (via `__config_site`) about whether filesystem is disabled?

I guess hardcoding msvc could be argued for, because the dllexport behaviour is kinda msvc specific (this problem doesn't manifest in mingw builds, that build successfully in dll mode).

Another reason for not hardcoding it for msvc, is that while filesystem is disabled for now, it hopefully won't be for long, and it'd be nice not to have an extra condition to keep track of to update in sync.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94824/new/

https://reviews.llvm.org/D94824