[libcxx-commits] [PATCH] D94824: [MSVC] Disable <fstream> usage of <filesystem>

Reid Kleckner via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 15 13:58:50 PST 2021

rnk created this revision.
rnk added reviewers: mstorsjo, ldionne.
rnk requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

`ninja cxx` now succeeds for me locally.

This fixes link errors when producing a DLL for libc++ with clang-cl.
When building a DLL, most of <filesystem> is annotated as dllexport.
When a class is marked dllexport, all of its inline functions are
emitted into the object file. Those inline functions reference
out-of-line functions that are not available because the filesystem cpp
files are not built on Windows because they haven't been ported yet.

  rG LLVM Github Monorepo



-------------- next part --------------
A non-text attachment was scrubbed...
Name: D94824.317067.patch
Type: text/x-patch
Size: 4263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210115/46e1f16f/attachment.bin>

More information about the libcxx-commits mailing list