[libcxx-commits] [PATCH] D94511: Implement p0586r2

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added a comment.

FWIW, you can take a look at the stub I've started writing at https://github.com/mkurdej/llvm-project/commit/0b7eccea2fbab13e897502c6d44ff958a0d550a9.
You might have a look at tests and other stuff like extended integer types.
It's just a WIP and far from ready though, so use with caution.



================
Comment at: libcxx/include/utility:308
+concept __is_safe_integral_cmp = is_integral_v<_Ty> &&
+                      !__is_any_of<remove_cvref_t<_Ty>, bool, char, char8_t, char16_t, char32_t, wchar_t, byte>::value;
+
----------------
You need to guard the use of char(8|16|32)_t.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94511/new/

https://reviews.llvm.org/D94511