[libcxx-commits] [PATCH] D94511: Implement p0586r2

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 12 10:04:45 PST 2021

curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.

The implementation looks okay at the first glance but you need to rework the tests.

- Test noexcept using ASSERT_NOEXCEPT
- Add tests in non-constexpr context. Look at other recently added commits and add a test function with asserts that gets called twice, once normally (runtime) and once in static_assert.
- Split tests for each added function. Please follow the naming of test files according to the standard paragraphs.
- Add more tests with all sorted integer types and extended integer types.
- Test various values and their combinations: 0 limits::min/max +-1, min/2, max/2 and so on. Test interesting combinations of different types

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list