[libcxx-commits] [PATCH] D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/src/random.cpp:37
+#ifdef __OpenBSD__
+#include <limits>
+#endif
----------------
brad wrote:
> ldionne wrote:
> > You can include this unconditionally. Please include it alongside `"random"` and `"system_error"` above.
> > You can include this unconditionally. Please include it alongside `"random"` and `"system_error"` above.
> 
> Ah. The original diff was like that. I figured you would want it guarded like this.
> 
> Immediately below them? In the same form? "limits" or as is?
Just `#include "limits"`. It's a header provided by libc++, and compile-times are not really a concern for building the libc++ library, so I prefer to go for simplicity and removing as many `#ifdef`s as I can.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94571/new/

https://reviews.llvm.org/D94571