[libcxx-commits] [PATCH] D94571: [libcxx] random_device, for OpenBSD specify optimal entropy properties

Brad Smith via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Jan 13 08:23:29 PST 2021


brad added inline comments.


================
Comment at: libcxx/src/random.cpp:37
+#ifdef __OpenBSD__
+#include <limits>
+#endif
----------------
ldionne wrote:
> You can include this unconditionally. Please include it alongside `"random"` and `"system_error"` above.
> You can include this unconditionally. Please include it alongside `"random"` and `"system_error"` above.

Ah. The original diff was like that. I figured you would want it guarded like this.

Immediately below them? In the same form? "limits" or as is?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94571/new/

https://reviews.llvm.org/D94571



More information about the libcxx-commits mailing list