[libcxx-commits] [PATCH] D35388: [libc++] Give extern templates default visibility on gcc

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Jan 12 11:15:38 PST 2021

ldionne removed a reviewer: EricWF.
ldionne added a subscriber: EricWF.
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D35388#2493696 <https://reviews.llvm.org/D35388#2493696>, @smeenai wrote:

> It's been a long time since I've contributed to libc++, and the pre-merge CI setup is a massive improvement over what we had before. A huge kudos to everyone who made it possible :)

I'm glad this is helpful! It's a huge time saver for me so far.

> This is still showing up as Needs Review. I'm not sure if that's because of @EricWF's prior "Needs Revision" or because it needs to be explicitly accepted as the libc++ group (or some combination of the two).

It must be because of Eric's "Needs Revision", because I accepted as libc++. I'll remove Eric as a reviewer to fix this (Eric, if you see this, it's not against you!).

  rG LLVM Github Monorepo



More information about the libcxx-commits mailing list