[libcxx-commits] [PATCH] D35388: [libc++] Give extern templates default visibility on gcc

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added a comment.

It's been a long time since I've contributed to libc++, and the pre-merge CI setup is a massive improvement over what we had before. A huge kudos to everyone who made it possible :)

This is still showing up as Needs Review. I'm not sure if that's because of @EricWF's prior "Needs Revision" or because it needs to be explicitly accepted as the libc++ group (or some combination of the two).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D35388/new/

https://reviews.llvm.org/D35388