[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.contains/contains.ptr.pass.cpp:48
+    assert( s3.contains("de"));
+    assert( s3.contains("cd"));
+    assert( s3.contains("cde"));
----------------
I think you lack some test cases like:
`assert(!s3.contains("ce"));`
That is all characters exist in the string but not in this order.
Also, "ced" - permutation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912