[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

[Wim Leflere via Phabricator via libcxx-commits]

WimLeflere updated this revision to Diff 315454.
WimLeflere added a comment.

Merged main with changes from D94227 <https://reviews.llvm.org/D94227> and D93830 <https://reviews.llvm.org/D93830>.

@Mordante 's question is still open

> Wouldn't it be better to use constexpr and noexcept since the code is never compiled using C++98.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93912/new/

https://reviews.llvm.org/D93912

Files:
  libcxx/docs/FeatureTestMacroTable.rst
  libcxx/include/string
  libcxx/include/string_view
  libcxx/include/version
  libcxx/test/std/language.support/support.limits/support.limits.general/string.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/string_view.version.pass.cpp
  libcxx/test/std/language.support/support.limits/support.limits.general/version.version.pass.cpp
  libcxx/test/std/strings/basic.string/string.contains/contains.char.pass.cpp
  libcxx/test/std/strings/basic.string/string.contains/contains.ptr.pass.cpp
  libcxx/test/std/strings/basic.string/string.contains/contains.string_view.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/contains.char.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/contains.ptr.pass.cpp
  libcxx/test/std/strings/string.view/string.view.template/contains.string_view.pass.cpp
  libcxx/utils/generate_feature_test_macro_components.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D93912.315454.patch
Type: text/x-patch
Size: 19616 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210108/edf3feae/attachment-0001.bin>