[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

Wim Leflere via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Jan 8 03:29:22 PST 2021

WimLeflere added a comment.

In D93912#2485571 <https://reviews.llvm.org/D93912#2485571>, @mclow.lists wrote:

> This looks like WAY too much code for "add string contains".

The bulk of the changes are coming from introducing C++2b in the generate_feature_test_macro script.
This generates a lot of  C++2b feature macro tests which are not directly related to `string contains`.

Should introducing C++2b in the generate_feature_test_macro script be done in a separate review?

In D93912#2485579 <https://reviews.llvm.org/D93912#2485579>, @ldionne wrote:

> In D93912#2485543 <https://reviews.llvm.org/D93912#2485543>, @WimLeflere wrote:
>> Added feature test macro to script and updated generated files.
> Thanks for your contribution! I think you should try rebasing against `main`, as most of the changes @curdeius was discussing have been checked in now (thanks Marek!).
> I believe that should remove the need for most of the boilerplate/generated stuff in this patch, which should end up being much simpler. I see you added tests and updated the synopsis, that's great.

The patch was created after rebasing on `1a2eaeb`.
Should I wait for other changes?



More information about the libcxx-commits mailing list