[libcxx-commits] [PATCH] D93912: [libc++][P1679] add string contains

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Jan 7 14:50:01 PST 2021

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

In D93912#2485543 <https://reviews.llvm.org/D93912#2485543>, @WimLeflere wrote:

> Added feature test macro to script and updated generated files.

Thanks for your contribution! I think you should try rebasing against `main`, as most of the changes @curdeius was discussing have been checked in now (thanks Marek!).

I believe that should remove the need for most of the boilerplate/generated stuff in this patch, which should end up being much simpler. I see you added tests and updated the synopsis, that's great.



More information about the libcxx-commits mailing list