[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

Marek Kurdej via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sun Feb 28 05:11:43 PST 2021


curdeius added inline comments.


================
Comment at: libcxx/cmake/Modules/HandleLibCXXABI.cmake:55
 
-        if (LIBCXX_HEADER_DIR)
-          set(dst "${LIBCXX_HEADER_DIR}/include/c++/v1/${dstdir}/${fpath}")
+        if (LIBCXX_GENERATED_INCLUDE_DIR) # always true
+          # TODO: libc++ shouldn't be responsible for copying the libc++abi
----------------
If it's always true, then the condition should be removed, no?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572



More information about the libcxx-commits mailing list