[libcxx-commits] [PATCH] D97572: [libc++] Include <__config_site> from <__config>

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I think it would be great to try it out again. To be honest, I've been meaning to try it out again (I had a similar patch locally), but I've been too scared to do so. Last time the world just exploded and I spent like a week trying to make heads or tail of the situation.

I'm entirely favorable to doing this, but can we try splitting out changes as much as possible? Ideally, we'd land everything before, and then at the end we'd land the libc++ changes, and only those.

Also, it would be awesome to set up a true runtimes build on our pre-commit CI infrastructure. The GCE instances we use could probably handle the load, they're very beefy. Would you be willing to help set that up?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97572/new/

https://reviews.llvm.org/D97572