[libcxx-commits] [PATCH] D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics

[Zibi Sarbino via Phabricator via libcxx-commits]

zibi marked an inline comment as done.
zibi added inline comments.


================
Comment at: libcxx/src/CMakeLists.txt:213
   if (LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY)
-    if (APPLE)
+    if (ZOS)
+      target_link_libraries(cxx_shared PRIVATE "${LIBCXX_CXX_STATIC_ABI_LIBRARY}")
----------------
ldionne wrote:
> What's the issue with using `--whole-archive` on z/OS? Also, if you don't use `--whole-archive`, some symbols in libc++abi might not be available from the dylib you build, so you'll end up with a malfunctioning/incomplete libc++.
Linker on z/OS does not support this option. When `-Wl,--whole-archive` is used the linker wants to include an object of that name and issues an error. Not sure if  incomplete libc++ will apply to z/OS due to linker differences. If you know which symbol(s) might be missing let me know and I can check. Perhaps there is an existing test which will fail when those symbols are not present in libc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97321/new/

https://reviews.llvm.org/D97321