[libcxx-commits] [PATCH] D97321: [SystemZ][ZOS] Remove --whole-archive & --color-diagnostics

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/src/CMakeLists.txt:213
   if (LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY)
-    if (APPLE)
+    if (ZOS)
+      target_link_libraries(cxx_shared PRIVATE "${LIBCXX_CXX_STATIC_ABI_LIBRARY}")
----------------
What's the issue with using `--whole-archive` on z/OS? Also, if you don't use `--whole-archive`, some symbols in libc++abi might not be available from the dylib you build, so you'll end up with a malfunctioning/incomplete libc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97321/new/

https://reviews.llvm.org/D97321